Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hostAliases to helm chart #1662

Merged
merged 6 commits into from
Oct 28, 2024
Merged

add hostAliases to helm chart #1662

merged 6 commits into from
Oct 28, 2024

Conversation

duncan485
Copy link
Contributor

Add hostAliases to alloy pod

Notes to the Reviewer

I'd like to be able to add hostAliases to the pod. Any feedback is welcome

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • [? ] Config converters updated

@duncan485 duncan485 requested a review from a team as a code owner September 11, 2024 13:26
Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@wildum
Copy link
Contributor

wildum commented Oct 14, 2024

@petewall another helm chart PR

Copy link
Contributor

@petewall petewall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@wildum
Copy link
Contributor

wildum commented Oct 14, 2024

@duncan485 thanks for contributing and sorry for looking at the PR so late. There is a lint issue, would you mind rebasing your branch with main and running make rebuild-tests again please?

@duncan485
Copy link
Contributor Author

Hey @wildum . Thanks! No problem, took me a while to get back to this as well. I rebased it and rerun the make rebuild-tests

@duncan485
Copy link
Contributor Author

hey @wildum I see there is still a test failing, is there anything I can do about it ? I'm not sure it's related to the Chart.

@wildum
Copy link
Contributor

wildum commented Oct 28, 2024

hey @wildum I see there is still a test failing, is there anything I can do about it ? I'm not sure it's related to the Chart.

Hey sorry about that, this seems to be a flaky test from an experimental WAL feature that we are testing. As long as the tests run in drone then we are fine, it's not a blocker for this PR

@wildum wildum merged commit 290f06b into grafana:main Oct 28, 2024
14 of 15 checks passed
@wildum
Copy link
Contributor

wildum commented Oct 28, 2024

Merged! Thanks again for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants